SEZ9 commented on PR #12015: URL: https://github.com/apache/seatunnel/pull/12015#issuecomment-6104499650
@luozihen Thanks for the update, and glad the MinIO problem went away after syncing with `dev`. On the `elasticsearch-connector-it` failure: every commit on this branch after `00acc23a5` (`0361012392`, `1e667b60c`, `8a3d619c9`) is a merge of `dev`, and the diff of the PR-owned files between `00acc23a5` and `8a3d619c9` is empty, so the author code is unchanged since my last review and that failure is unlikely to come from this PR's own changes. Please don't add an ES-specific workaround to this branch; once `dev` is fixed, merge it again and re-run. For the PR itself, I have no new source-side concerns on `8a3d619c9`. Since the author code is unchanged since `00acc23a5`, the points from my earlier review that are still open stand as written there. Thanks for your patience with the CI. <!-- streview-comment:1659 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
