SEZ9 commented on issue #12655:
URL: https://github.com/apache/seatunnel/issues/12655#issuecomment-6105263286
Thanks @Rangsh, that plan sounds right — a single implementation on #12662
rebased onto current `dev` is the way to go now that #11545 has merged and the
root argLine is `${surefire.jvm.args} ${surefire.module.args}`.
Concrete asks to close this out on the PR side:
1. Once #12662 is rebased, confirm in the PR description that
`connector-lance/pom.xml` no longer carries its own Surefire `<argLine>` or the
`java9+` `--add-opens` profile, and that the `darwin-aarch64` profiles contain
only the `os.arch` / `os.name` overrides.
2. Keep the diff limited to that POM behavior (the ASF-header whitespace
changes should be reverted); the `SUREFIRE_JVM_ARGS` cleanup in
`.github/workflows/backend.yml` stays a separate follow-up PR after the POM
change lands.
3. Post the JDK 17 `connector-lance` test command and result with
`-Dsurefire.jvm.args` deliberately excluding the `--add-opens` values, so we
can see the flags arriving via `${surefire.module.args}`. The fork workflow
also needs to be enabled on #12662 so the Build check can actually run.
4. Attach the local `<argLine>` / `surefire.jvm.args` override scan to the
later workflow PR rather than this one.
Please link both PRs back to this issue and ping here once #12662 is rebased
and green — I'll review promptly.
<!-- streview-comment:1672 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
