SEZ9 commented on issue #12655:
URL: https://github.com/apache/seatunnel/issues/12655#issuecomment-6116597660

   Thanks @Rangsh, that status is clear and matches the plan.
   
   On the four points:
   
   1. Good — dropping the connector-level Surefire `<argLine>`, the `java9+` 
profile and the `darwin-aarch64-java9+` profile, and leaving `darwin-aarch64` 
with only the `os.arch` / `os.name` overrides, is exactly the intended scope.
   2. Agreed — the POM-only diff is correct, and the `backend.yml` cleanup plus 
the local-override scan stay in the later PR.
   3. Noted that the JDK 17 run (`BUILD SUCCESS`, 28 tests, 0 failures) with 
`-Dsurefire.jvm.args` excluding `--add-opens` is on the PR. That is the 
evidence we need; the remaining gap is just getting it exercised in CI.
   4. Understood on the 403 — you cannot push to the fork branch, and I agree 
you should not open a second PR.
   
   Since the rebased commit (`6ef132fee`, on top of `83603e19`) is ready 
locally but cannot land on #12662 without the fork owner, the remaining asks 
are:
   
   - Please attach the rebased patch (or a link to the commit in your own fork) 
on #12662 so the fork owner can pull it onto the PR branch, or grant you push 
access to that branch.
   - Once the rebased head is on #12662 and Actions are enabled in the fork, 
ping here and I will review the PR and the Build result together.
   
   No review on this issue until then, as you said.
   
   <!-- streview-comment:1687 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to