CodeWithPravinMaske commented on PR #12608: URL: https://github.com/apache/seatunnel/pull/12608#issuecomment-6118884136
Thanks @DanielLeens for the thorough re-review, including the token-level comparison with the Debezium sources. **Issue 1 (exactly-once range check with a NULL key).** Agreed, this PR should land after #12597, or together with it. - #12597 now also guards the primary key branch, so a nullable column is never used as the snapshot split column, whether it comes from a unique key, `snapshotSplitColumn` or `table-names-config.primaryKeys`. The exactly-once range check therefore never compares a NULL split key. - The PR description now has a "Merge order" note explaining this. - The `incompatible-changes.md` entry (en/zh) says the change relies on nullable columns no longer being used as the snapshot split column. **Issue 2 (`exactly_once = true` collapses NULL-key rows).** Added a sentence to the MySQL-CDC note (en/zh): with `exactly_once = true`, rows whose key is NULL cannot be told apart, and only one of them is kept per snapshot split, so use a NOT NULL key. This round only changes docs. CI: the `ElasticsearchIT` failures come from `dev` (#12711). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
