CodeWithPravinMaske commented on PR #12608: URL: https://github.com/apache/seatunnel/pull/12608#issuecomment-6139205225
Thanks @SEZ9! Those five points are from the first version of this PR and are all resolved in the current head: `restoreNullableColumns` was removed (so the null guard, the Javadoc and the per-column `log.info` are gone) and the fix moved into the `MySqlAntlrDdlParser` override, which also covers `parseStreamingDdl` and the checkpointed history (see my earlier comment with code links). The docs and `incompatible-changes.md` note are in (en/zh), and a nullable `primaryKeys` column now emits NULL (`MySqlSchemaTest#testNullableColumnConfiguredAsPrimaryKeyEmitsNull`). I'll merge `dev` once #12597 lands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
