88fantasy commented on PR #12208: URL: https://github.com/apache/seatunnel/pull/12208#issuecomment-6120709054
@DanielLeens Thanks again for the thorough reviews across the three rounds. I've synced this branch with the latest `dev` and addressed the two remaining non-blocking items from your last pass: - **Issue 3** — added `OpenLineageOptionSyncTest` so `EnvCommonOptions` OpenLineage keys/defaults stay aligned with `LineageConfig` (test-scoped dependency only; no compile-time api→lineage edge). - **Issue 4** — introduced a `LineageDatasetExtractor` SPI (ServiceLoader) and moved the Paimon / Doris / JDBC parsers into dedicated extractors; `LineageDatasetFactory` now only discovers and delegates. Earlier blockers (exception containment in `LineageRuntime.emit`, docs Markdown heading / license layout) and the other suggestions (blocking-bound Javadoc, stricter `asBoolean`) remain in place on this head. Head: `a2e66f52d`. Could you please take another look when you have a moment? Also noting that a committer Approve is still needed for branch protection since your reviews are comment-only — happy to follow up with maintainers if you have a suggested reviewer. Local validation on this head: lineage module tests (36) and openlineage backend tests (9) passed; Spotless checked on the touched modules. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
