88fantasy commented on PR #12208: URL: https://github.com/apache/seatunnel/pull/12208#issuecomment-6136242868
@DanielLeens Thanks for the re-review on `a2e66f52d`. Addressed the three non-blocking notes on the extractor SPI in `61ece4fae`: - **Issue 1** — `LineageDatasetFactory` now loads extractors with this module’s class loader and skips broken providers (`ServiceConfigurationError`) so one bad entry cannot poison class init or pin a job loader. - **Issue 2** — Documented that named-connector extractors must use `order() < 100`; added a Doris+`url` precedence test and built-in order asserts (Paimon 10 < Doris 20 < JDBC 100). - **Issue 3** — Documented null/fallback semantics on the public `LineageDatasetOptionSupport` helpers. Happy to take another look when you have a moment. CI on this head still needs a Build run from the fork; I’ll trigger that separately if it has not started yet. A committer Approve is still needed for branch protection. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
