DanielLeens commented on PR #11307: URL: https://github.com/apache/seatunnel/pull/11307#issuecomment-6135260621
Quick CI follow-up for head `d55343e8cb`, since my last review described the fork `Build` run as still in progress. That run (`goutamadwant/seatunnel` run 38091447278) has now completed with a failure. The failed jobs are `unit-test (11)` (`SavePointTest.testSavePointButJobGoingToFail`, an engine savepoint test), `engine-k8s-it (11/17)` (the `install k8s` step, as noted before), `elasticsearch-connector-it (11/17)`, `all-connectors-it-6 (17)`, `doris-connector-it (17)` and `rocketmq-connector-it (11)`. None of these touch Spark launcher code, and the Windows launcher lanes that gated my approval stayed green. My read (an inference from the failing job names and logs, not a code-path proof) is that these are environmental or already-known engine/IT flakes rather than something this diff causes. The Elasticsearch IT visibility flake was addressed on `dev` after this run by #12711. Suggested next step: sync with the latest `dev` (currently 20 commits behind) and rerun only the failed jobs (`gh run rerun <run-id> --failed`, or "Re-run failed jobs" in the Actions UI). My source-level conclusion is unchanged: no blockers from my side; the earlier non-blocking items still apply. As noted, the final approval needs a write-capable maintainer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
