SEZ9 commented on PR #11307: URL: https://github.com/apache/seatunnel/pull/11307#issuecomment-6258872669
Thanks for the follow-up pushes. Checking the latest state at `cadcf87e74` against my earlier findings: **Looks addressed (pending verification)** - **PR11307-F1 / PR11307-F5 (Windows launcher)** – the `.cmd` no longer relies on delayed expansion and preserves the child exit code, which is what I asked for. However, the Windows packaged-launcher IT has still not actually executed on a Windows runner, so the seven packaged cases remain unproven. Please link a Windows run that executes them before merge. - **PR11307-F2 / PR11307-F6 (`eval` + unquoted args in the `.sh` launcher)** – the NUL-delimited argv handoff is the right direction. Could you confirm the `eval` path is fully gone, and share a quick manual run with a config path containing spaces and an embedded single/double quote so we can see quoting survives end to end? - **PR11307-F3 (3.3 translation layer on 3.5)** – the runtime row-encoder adapter (`Encoders.row(StructType)` on 3.5 with the `RowEncoder.apply` fallback) is a reasonable way to contain the Catalyst binary-compat risk. Fine with this as long as the tests below land. **Still open** - **PR11307-F7 (streaming coverage on 3.5.8)** – I don't see a streaming test yet, while the docs still point 3.5 users at the streaming template. A single micro-batch streaming IT on 3.5 would close this. - **PR11307-F4 (`log4j-slf4j-impl` + `log4j-slf4j2-impl` both in the starter logging jar list)** – no update yet. Please drop one of them or explain why both are safe on the launcher classpath. - **PR11307-F8 (Spark 3.4.x guidance)** – the docs still narrow the Spark 3 starter to "3.3.x". Please either state which starter 3.4.x users should use or say explicitly that 3.4.x is untested. **CI** – the required `Build` is failing on this head, and the earlier run `38091447278` on `d55343e8cb` failed in jobs unrelated to the launcher code. Please sync with current `dev` and rerun so we have a green `Build` for the exact commit under review. Once the Windows run, the quoting check, the streaming test and the F4/F8 fixes are in, I'm happy to do a final pass. <!-- streview-comment:1865 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
