SEZ9 commented on PR #12333: URL: https://github.com/apache/seatunnel/pull/12333#issuecomment-6136900953
@wgzhao thanks for going through all five — a separate follow-up is fine with me. They're all Low and behaviour-neutral, so there's no need to churn this branch; I'm happy for this PR to go in as-is with the cleanup landing in one small follow-up as you propose. On the plan itself: 1. **Whitelist drift** — deriving the set from the `MYSQL_*_UNSIGNED` constants in `MySqlTypeConverter` plus a unit test asserting every constant's base name is accepted is exactly what I had in mind. Please keep that test; it's what makes drift fail loudly. 2. **`DATA_TYPE`** — `isNumericUnsignedColumnType(String dataType, String columnType)` sounds right, with the catalogs all going through that one entry point. 3. **OceanBase IT** — mirroring the assertions into `JdbcOceanBaseMysqlIT` covers it. 4. **Javadoc** — agreed, reword only; membership stays for parity with `MYSQL_BIT_UNSIGNED` / `MYSQL_YEAR_UNSIGNED`. 5. **Placement** — moving the helper next to the constants and having `OceanBaseMySqlCatalog` call the same method bundles naturally with (1). When you open the follow-up, please link it back here so the trail is easy to find. Nothing else outstanding from my side on this PR. <!-- streview-comment:1706 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
