wgzhao commented on PR #12333: URL: https://github.com/apache/seatunnel/pull/12333#issuecomment-6137068934
Follow-up opened: #12742 — `[Improve][Connector-V2][JDBC] Derive the MySQL UNSIGNED guard from the converter constants`. It lands all five points: the guard moves into `MySqlTypeConverter` next to the `MYSQL_*_UNSIGNED` constants and derives its base-type set from them (with a test that reflects over the constants, so drift fails CI), it takes `DATA_TYPE` alongside `COLUMN_TYPE`, `OceanBaseMySqlCatalog` calls the same method, the set's javadoc stops claiming it mirrors both converters, and `JdbcOceanBaseMysqlIT` gets the regression case. One thing worth flagging on point 3: only the ENUM half of the MySQL assertions could be mirrored. `OceanBaseMySqlTypeConverter` has no `MYSQL_SET` case at all, so a SET column fails discovery on OceanBase with or without the guard — the guard is not the deciding factor there. The ENUM shape reproduces the #10451 failure exactly (`ENUM UNSIGNED` before, `ENUM` after), so that is the reachable half; the reasoning is in the PR body. The follow-up is stacked on this branch's head, so until this PR merges it also carries these commits; once it lands the follow-up diff reduces to its single commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
