SEZ9 commented on PR #12165: URL: https://github.com/apache/seatunnel/pull/12165#issuecomment-6137178535
@Vivek1106-04 Thanks for picking up the benchmark first and keeping the analysis in https://github.com/apache/seatunnel/pull/12418#issuecomment-6135494803 — that is the right split, and @nzw921rx's observation that the CV shrinks as pipelines increase should be settled before an efficiency comparison of this PR means much. Nothing has changed on the code side here: the CI attribution on fork run `35729456152` for head `c773cc091` still holds as long as no new commit lands on top of it. Once the benchmark fix is merged and you rerun the comparison of this PR against `dev`, please post the result in this thread as well, and call it out explicitly if the rerun requires a new head beyond `c773cc091` so the attribution can be redone against the new run rather than carried over. Nothing else outstanding from my side. <!-- streview-comment:1712 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
