SEZ9 commented on PR #12165: URL: https://github.com/apache/seatunnel/pull/12165#issuecomment-5842328421
@Vivek1106-04 Thanks for the update. Good to hear the follow-up fix now covers both regressions, that both are red on `c773cc091` and green with your fix, and that you're holding that PR until this one merges so it doesn't carry these commits again — rebasing onto `dev` and opening it once this lands sounds right. Nothing has changed on my side since my last comment: the PR description point is closed, and the per-job attribution on fork run `35729456152` for `c773cc091` met the bar I set, so I'm not asking for any further code changes or reruns. I've already approved this PR. Your request for a committer's final look stands as written — I'll leave that to whoever picks it up. <!-- streview-comment:1318 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
