DanielLeens commented on PR #12172: URL: https://github.com/apache/seatunnel/pull/12172#issuecomment-6165042294
Quick CI follow-up, since the fact I cited in my review has changed: the head is now `790cefca3` with the latest `dev` merged in (so the Cassandra Flink 1.20 failure fixed by #12756 is gone, and no further sync is needed). The Build on this head is red on two different jobs, and neither touches this PR's diff, which is confined to `seatunnel-formats` (`JsonDeserializationSchema`, `DebeziumJson*Schema`, `DebeziumRowConverter` and their unit test): - `all-connectors-it-6 (17)`: `DatabendCDCSinkIT.testDatabendSinkCDC` hit a `ConditionTimeout` at `DatabendCDCSinkIT:88` after ~200 s. The Databend E2E module has no reference to the Debezium JSON format. - `connector-file-local-it (11)`: `LocalFileIT.testLocalFileBinaryUpdateModeContinuousDiscoveryWithNonRecursiveScan` failed in `cancelContinuousJob` (`LocalFileIT:610 -> :960`), a job-cancel timing path in the local file connector, also unrelated to this diff. Both look like infrastructure/timing flakes rather than anything introduced here. The lowest-cost next step is to re-run just those two failed jobs in your fork's Actions run (https://github.com/Rangsh/seatunnel/actions/runs/38495137099); no code change is needed on this branch. My conclusion stays "Ready to merge": no source blocker on my side, and the remaining gate is a green rerun plus a committer approval. Static review only; I did not execute the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
