SEZ9 commented on PR #12443:
URL: https://github.com/apache/seatunnel/pull/12443#issuecomment-6183452128
Thanks for the follow-up on `871c6448a8d1`. The comment above describes how
each earlier point was addressed, but I can only mark findings resolved against
the actual diff, so a few pointers would help:
- **F1 / F5** – The guard is described as now living in a shared helper and
being applied on both the REST Map→Config hop and the shade/decrypt hop. Could
you point to the relevant hunks and to the test that pushes a regex key such as
`^t_nova_.*$` through `decryptConfig()` end-to-end?
- **F2 / F3** – Please link the EN/ZH doc change. Stating that quoted keys
stay literal only when the path parser rejects them does not by itself document
that `->` is still a separator or that embedded quotes/whitespace in
successfully parsed keys are rewritten; if that is the intended behaviour, it
should be spelled out as well.
- **F4 / F6** – Please point to the test cases covering the `->` separator,
the escape round-trip (`"`/`\` in keys), a top-level key, and a key whose only
offending token is `$`, `:` or `${...}`, so I can confirm they hit the quoting
branch rather than only a dotted key.
- **F7** – I'll keep this open until the set of changed modules is
confirmed; if modules beyond seatunnel-engine-server are touched, `[Fix][Core]`
is fine.
No further source-level concerns from my side within the reviewed scope.
<!-- streview-comment:1765 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
