DanielLeens commented on PR #11557: URL: https://github.com/apache/seatunnel/pull/11557#issuecomment-6190332170
Thanks @SEZ9, and thanks for confirming the two test names. Both remaining asks, checked against the current head `5dc655e6a91`: **1. Executed result on the head that will merge: not available yet, and I need to correct my earlier "Build queued" status.** The fork Build run [38352742729](https://github.com/DanielLeens/seatunnel/actions/runs/38352742729) on `5dc655e6a91` finished as cancelled, and the unit-test lanes failed before running any tests in `seatunnel-engine-server`: `SourceAssignmentTrackerTest.java:74` does not compile (`incompatible types: Collection<Entry> cannot be converted to List<Entry>`). The cause is in this PR's own latest commit: `SourceAssignmentTracker#entries()` returns `Collection<Entry>` (`SourceAssignmentTracker.java:328`), while the new `restoreShouldNotClaimCoordinatorOwnerThread` test assigns it to a `List<SourceAssignmentTracker.Entry>`. That test-compile failure blocks every test in that module, including `ManagedSourceRegisterOperationSerializationTest`, so I cannot give you an honest executed result for `5dc655e6a91` until it is fixed. A one-line test fix (copy into a `Lis t`, or declare the variable as `Collection`) is needed in a new commit; I will push it and then post the per-test result for `ManagedSourceRegisterOperationSerializationTest` with the job link on the new head. Please keep F1 open until then. (A separate `connector-sls` job in that run failed only on a Maven Central `Connection reset` while downloading `lz4`, which is environmental.) **2. Legacy follow-up issue.** It is filed as #12747 (`[Improve][Zeta] Validate wire types in legacy task operations`), covering `AssignSplitOperation#readInternal` and `TaskOperation#readInternal`. The PR description does not link it yet; I will add the link in the same update so the scope boundary is visible without reading the thread. I will re-check both items on the new head once it is pushed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
