DanielLeens commented on PR #11495:
URL: https://github.com/apache/seatunnel/pull/11495#issuecomment-6190329968

   CI correction for head `9c047310570519504bd5d37be03421b46b377dba`: in my 
last review I said the required `Build` run was still in progress. That has 
changed. The apache-side `Build` check on this head now shows `success`, so the 
technical state from my side is: no source-level blocker and CI green; only the 
maintainer approval gate remains.
   
   Regarding @SEZ9's latest questions (the limitation statement about a worker 
whose clean operation fails, where the "counters reset on retry" behavior is 
documented, and whether any test goes beyond mock invocation): those are 
directed at the author. I agree they are worth a short answer in the PR 
description, in particular stating plainly whether a still-alive worker whose 
`CleanTaskGroupContextOperation` fails could re-report the old attempt's 
counters, so the PR does not over-claim a complete fix for #11472. I will 
re-check once a new commit or description update lands.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to