wgzhao commented on PR #12775: URL: https://github.com/apache/seatunnel/pull/12775#issuecomment-6191917927
Thanks @DanielLeens for the careful pass and for writing up the review in such a readable form. Both notes are addressed in the new head `363bb2244`, which is also rebased onto current `dev` (`c37823b9a`, the branch had been 10 commits behind). **Issue 1 - filter order vs basic auth is now covered by a test.** `RestApiHttpBasicTest` runs against a node with `enable-basic-auth` on, so `testFragmentRedirectRequiresAuthentication` asserts `GET /%23/overview` answers `401` without credentials and `302 Location: /#/overview` with them. A later reordering of the two filter registrations now fails that test instead of silently changing the security behavior. The IT runs with auth disabled, so it could not cover this. **Issue 2 - proxy prefix is documented.** `docs/en/engines/zeta/web-ui.md` and `docs/zh/engines/zeta/web-ui.md` now state that the redirect is built from the configured `context-path` and that a prefix a reverse proxy strips before forwarding is not part of the redirect target. **Your test-stability note.** `WebUiEntryPointIT` now asserts up front that the packaged Web UI resources are on the classpath and fails with an explicit message, instead of reporting a misleading 404 for the two UI cases when someone runs it with `-Dskip.ui=true`. Local verification after the rebase (JDK 17): ``` RestApiHttpBasicTest Tests run: 4, Failures: 0, Errors: 0 (includes the new case) WebUiFragmentRedirectFilterTest Tests run: 7, Failures: 0, Errors: 0 WebUiEntryPointIT Tests run: 6, Failures: 0, Errors: 0 ``` `./mvnw spotless:apply` is clean. CI is re-running on the new head, so the `engine-v2-it` lane and the unit-test lanes should report shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
