wgzhao commented on PR #12775:
URL: https://github.com/apache/seatunnel/pull/12775#issuecomment-6210477524
Thanks @DanielLeens - the blocker is real and it was mine. I reproduced it
locally before touching anything: with the UI resources taken off the
classpath, `RestApiHttpBasicTest#testFragmentRedirectRequiresAuthentication`
fails exactly like the unit-test lanes (`UI resources not found in classpath`,
then `expected: <302> but was: <404>`), and my earlier local runs only stayed
green because my working tree has the built UI under `src/main/resources/ui`.
I took option A on the new head `e2bd2d148`.
`seatunnel-engine-server/src/test/resources/ui/index.html` is now a small
placeholder UI, so `getResource("ui")` resolves in that lane and the filter is
registered exactly like on a node that serves the UI, with the 401/302
assertions untouched. That needed one `.gitignore` negation, because the
existing `**/ui/*` rule also covered the new test resource; the built UI under
`src/main/resources/ui` is still ignored. Verified by masking the UI from the
classpath again: `RestApiHttpBasicTest` 4/4 and
`WebUiFragmentRedirectFilterTest` 9/9 with no UI present, and with the UI
present the same tests plus the whole REST area (113/113) are green.
Issue 2: the prefixed node now runs in its own cluster (`..._seatunnel`).
The IT log no longer shows the second node joining the first or the heartbeat
timeout that followed, so the case no longer depends on a Hazelcast join and a
member leave.
Issue 3: `%HH` is now checked with a small ASCII hex helper instead of
`Character.digit`, and `x=%٣٣` (Arabic-Indic digits, which `Character.digit`
maps to 3) is one of the refusal cases in the unit test.
`WebUiEntryPointIT` is 7/7 on `e2bd2d148` and `./mvnw spotless:apply` is
clean. CI is running on the new head; if the two unrelated lanes you listed
fail again on their timing, I will retry only those jobs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
