SEZ9 commented on issue #12819: URL: https://github.com/apache/seatunnel/issues/12819#issuecomment-6207555232
Thanks for breaking this out of #12366. Please state the proposed default policy explicitly in the issue (e.g., fail-fast with a clear error vs. drop-and-log/metric) and whether it should be configurable, so reviewers can agree on the contract before the PR. Please confirm how 'skipped tables' are currently identified in MultiTableSink (e.g., tables excluded at prepare/commit time) and document the difference between a deliberately skipped table and an unknown table ID in the routing contract, since the acceptance criteria require both to be consistent. For tests, consider covering: (1) a row with an unknown table ID, (2) a row for a skipped table, (3) a mixed batch of known/unknown IDs to ensure no silent misrouting to a default/first sink, plus a short doc note in the connector sink docs or Javadoc of MultiTableSink. <!-- streview-comment:1798 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
