SEZ9 commented on issue #12822: URL: https://github.com/apache/seatunnel/issues/12822#issuecomment-6228641044
Thanks @Rishavbhattarai for following up on the open points. `Authorization: Bearer <token>`, the `before` cursor set to the `token` of the last item, and the 1..1000 `page_size` range settle the API questions, and leaving `sort` out of v1 makes sense since `before` paging depends on the default order. The probe through the existing `HttpSourceReader` and `JsonDeserializationSchema` is reassuring. Documenting that `answers` is NULL for an empty answers array and pinning it in a unit test, rather than touching `JsonPathProcessorImpl` in this PR, sounds right. The design looks settled to me. Please go ahead and start `connector-http-typeform` from upstream/dev, keep it bounded-only with the mock-server coverage you described, and link the PR to this issue. I'll take care of the assignment. <!-- streview-comment:1813 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
