SEZ9 commented on issue #12822: URL: https://github.com/apache/seatunnel/issues/12822#issuecomment-6245811193
Thanks @Rishavbhattarai — happy for you to take this on. The bounded, single-form response reader with personal-access-token auth is the right first slice, and your probe through the existing HTTP base reader answers the main design questions. A few notes before the connector PR: 1. **API facts in the PR.** Please carry the verified items (Bearer scheme, `before` cursor using `token`, page-size default and maximum, rate limit, EU base URLs, freshness note) into the PR description with the doc links, without credentials. Giving `token` and `response_id` different values in the mock fixtures is a good way to prove which field is sent. 2. **Empty-array NULL.** Agreed that the connector PR should not change shared code. Please document the NULL result for an empty or missing `answers` in the connector docs and pin it in a unit test as you proposed. If you think the shared behavior should change, please raise that separately rather than folding it into this connector. 3. **Scope.** Keep v1 bounded-only and replay-tolerant, without `sort` as you suggested, and leave OAuth, persistent incremental state, and shared HTTP-client changes out. Mock-server coverage for paging, the terminal empty page, 429/5xx retry, filters, and no token leakage in logs or state should be in the first PR. Go ahead and open the PR and link it back here. <!-- streview-comment:1846 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
