DanielLeens commented on PR #11500:
URL: https://github.com/apache/seatunnel/pull/11500#issuecomment-6250247994

   I checked `b0101f3fc3febf46abfef48d404f25ac6792c9d1` against F1–F6.
   
   - F1 is covered both by the no-`slot-service` parser test and by the 
Kubernetes fixture, which explicitly keeps `dynamic-slot: false` and explains 
its static `slot-num: 8` override.
   - F2 and F3 are now explicitly documented in both incompatible-change pages, 
including the `seatunnel.sh -e local` cap and restore/master-switch resource 
re-evaluation.
   - F4/F5 are aligned in the EN/ZH deployment and Kubernetes docs; `slot-num: 
20` is labeled as an example/optional value rather than a default.
   - I do not see the unrelated JDBC converter deletion in the current code 
diff, so it should be removed from the PR description if it is still mentioned.
   
   I cannot close CI yet: Apache Build is failed for this exact head, pointing 
at fork run `39013187961`. GitHub's job endpoint is currently returning HTTP 
502, so I cannot classify the failed lane from the API. Please provide the 
failing job/log link or a successful rerun; then this is ready for final 
approval.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to