zhangshenghang commented on PR #11500: URL: https://github.com/apache/seatunnel/pull/11500#issuecomment-6363049929
Both threads are addressed in `e3dcf1c48..fe8b1b39c`: **Issue 1 (shared e2e skip changes)** — taking your 'move it out' path: `ContainerTestingExtension.java` and `ContainerUtil.java` are reverted to the dev versions and the PR-added `ContainerTestingExtensionTest.java` is deleted, so skip policy is left entirely to #12895. `test-compile` of `seatunnel-e2e-common` passes after the revert; nothing else in the PR referenced the removed additions. **@SEZ9's remaining asks** — verified at the current head: - The two migration sentences you asked for (local-mode `2 × availableProcessors()` cap; restore re-evaluation through `preApplyResources()`) are already present in the en `incompatible-changes.md` entry (lines 31-32) and mirrored in zh, as Daniel also confirmed. - The '(default)' snippet headings in the hybrid/separated deployment pages are reworded to state that the *mode* is the default and that the `slot-num` value is an example (en+zh). - One note: my first heading edit accidentally replaced the zh section's intro paragraph instead of the heading line; that regression is caught and fixed in the same series (`fe8b1b39c`) — the zh diff now reads exactly as intended. - The PR description no longer mentions `setNullToStatementByDataType` (verified). Please re-check the remaining two items (default-mode assertion and any leftover snippet pairing you had in mind) on this head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
