DanielLeens commented on PR #12605: URL: https://github.com/apache/seatunnel/pull/12605#issuecomment-6250166566
Thanks @SEZ9 — final source check on current head `7ab637bf1e202a798b7cfad0e1105c04527ed74f` confirms both remaining points. - The range failure no longer says `CAST`: `outOfIntRange` now says `Value ... cannot be converted to ...: out of range [...]` (`SystemFunction.java:166-180`), and its Javadoc explicitly records that `COALESCE`/`IFNULL` reach it without an explicit cast. It retains `UNSUPPORTED_OPERATION`, consistently with the existing SystemFunction invalid-conversion failures; the user-visible message is now conversion-based rather than misleadingly CAST-specific. - `numberToInt` is now documented as a range-checked narrowing conversion with its inputs, result and failure contract (`:112-128`). The brief numeric-family rationale is worth retaining because it prevents a superficially simpler `longValue()` refactor from reintroducing the exact wraparound bug; it is no longer a before/after release narrative. The wide-DECIMAL `COALESCE` case, `COALESCE`/`IFNULL` overflow, and prepare-time CAST behavior are all covered in the current test additions. Apache Build is green and I have no remaining source-side blocker; the final review/merge needs a write-access maintainer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
