dybyte commented on code in PR #12789:
URL: https://github.com/apache/seatunnel/pull/12789#discussion_r4308575254
##########
seatunnel-engine/seatunnel-engine-common/src/main/java/org/apache/seatunnel/engine/common/config/server/CheckpointConfig.java:
##########
@@ -51,6 +54,12 @@ public boolean isRetainAfterJobCancelled() {
return retainAfterJobCancelled;
}
+ public void setMonitorHistorySize(int monitorHistorySize) {
+ checkArgument(
+ monitorHistorySize >= 1, "The checkpoint monitor history size
must be at least 1.");
Review Comment:
Could we add an upper bound, or at least a WARN log when it's large?
##########
docs/en/architecture/fault-tolerance/checkpoint-mechanism.md:
##########
Review Comment:
Please also add `monitor-history-size` to the engine config reference
(`hybrid-cluster-deployment.md`, en/zh) next to `min-pause`. Users look up
seatunnel.yaml keys there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
