chovy-3012 commented on PR #12703: URL: https://github.com/apache/seatunnel/pull/12703#issuecomment-6253343165
Thanks for the thorough review. All 8 items are addressed in `2f0c133e8`: Issue 1: `getFormatter(pattern)` moved before the type dispatch and wrapped in `try/catch(IllegalArgumentException) → return null`, so a bad pattern sourced from a row column returns NULL instead of aborting the job. Issue 2: EN/ZH function docs expanded to cover offset-aware string parsing, NULL/invalid pattern → NULL for all input types, pattern consulted only for string input, no `timeZone` argument, and an `AT TIME ZONE` workaround example. Issue 3: Added "Zeta SQL Transform: built-in UNIX_TIMESTAMP" entry to EN/ZH `incompatible-changes.md` with behavior change / affected component / impact / migration guide, matching the AES_ENCRYPT/AES_DECRYPT precedent. Issue 4: `FORMATTER_CACHE` kept as cap-only `ConcurrentHashMap` (no eviction) by design; a 3-line comment on `FORMATTER_CACHE_MAX_SIZE` documents the rationale — 1024 is far beyond real-world distinct patterns, so the cache never fills in practice. Issue 5: `parseBest` chain extended with `ZonedDateTime::from` and `OffsetDateTime::from` before the local queries, so a string whose pattern carries a zone offset uses that offset. Issue 6: Pattern resolution (NULL check + `getFormatter` call) moved before the type dispatch, so NULL/invalid pattern returns NULL for all input types, not only string. Issue 7: Explicit `instanceof Number → null` (documented) and `!(value instanceof String) → throw TransformException` for other non-temporal types. Issue 8: E2E `func_unix_timestamp.conf` strengthened with `diff1` (equals_to 0) and `rt3` (equals_to "2023-01-01 00:00:00") exact-value assertions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
