hutiefang76 opened a new pull request, #12866:
URL: https://github.com/apache/seatunnel/pull/12866
Yes, contributing this fix to Apache SeaTunnel.
### Purpose of this pull request
Fixes #12863. With parse errors ignored, a malformed Maxwell JSON record
made the common parser return null. The Maxwell deserializer then dereferenced
it and failed the task.
Skip that rejected record before accessing its fields, following the
existing Canal/Ogg pattern. Extend the existing Maxwell suite with
ignored-input, strict-rejection and valid-record controls.
### Does this PR introduce any user-facing change?
Malformed Maxwell JSON is skipped when `ignoreParseErrors` is enabled.
Strict parsing still rejects malformed input; valid records, metadata and row
kinds keep their existing behavior. No configuration, default, dependency or
public API changes.
### How was this patch tested?
JDK 17.0.18:
- Added regression fails before the guard with the reported
NullPointerException.
- JSON format suite: 57 tests passed, zero failures/errors/skips, including
all four Maxwell tests.
- Scoped `spotless:apply` / build-time `spotless:check` passed.
- Root `./mvnw -q -DskipTests verify` passed; this command skips tests.
- Independent review of the complete two-file diff completed. Remote CI and
maintainer review remain separate.
Reproduction command for the affected format suites:
```sh
./mvnw -B -pl seatunnel-formats/seatunnel-format-json -am \
'-Dtest=org.apache.seatunnel.format.json.**.*Test' \
-Dsurefire.failIfNoSpecifiedTests=false package
```
### Check list
- [x] Regression tests added to the existing suite.
- [x] Formatting and required local verification completed.
- No new dependencies, connector registration or configuration changes.
<sub>Implementation and tests assisted by DeepSeek and Codex; this
description was drafted and posted by an AI assistant for @hutiefang76.</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
