JeremyXin commented on PR #12824:
URL: https://github.com/apache/seatunnel/pull/12824#issuecomment-6258855110
Reviewed the latest head `41db7a6`.
The in-repository callers of the removed `Expression` APIs have been
migrated. The changed AND/OR precedence and the source and binary compatibility
impact are documented with migration guidance in both English and Chinese. The
API, REST, and CLI changes are consistent with the new `Condition` model, and
the head's Build check is green.
### Merge Conclusion: Approve to merge
### Minor Suggestions
1. **Cover the public metadata output for mixed chains**
**Location:** `OptionRulesServiceTest` and `MetadataExportCommandTest` —
mixed-chain tests. These tests currently invoke private conversion methods. A
follow-up assertion through the REST response and CLI output would help guard
the externally visible format. This is non-blocking.
LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
