DanielLeens commented on PR #12824: URL: https://github.com/apache/seatunnel/pull/12824#issuecomment-6266155933
Following up on my earlier note so the state on this PR is accurate: **the merge conflict I reported is resolved** (you merged the latest `dev`), the head's `Build` check is green, and @JeremyXin's pass over `41db7a6` is consistent with my own re-review of that head. So to summarize where things stand: - **Blocking items:** none remaining from my side. - **Earlier note that no longer applies:** the "please sync with the latest `dev` and resolve the conflicts" request — done. - **Still open but non-blocking:** my Issues 1–3 from the original review, which are design notes rather than defects, plus @JeremyXin's suggestion about asserting the mixed-chain metadata output through the public REST/CLI surface instead of the private conversion methods. Both are reasonable follow-ups. - **Compatibility:** the changed AND/OR precedence for hand-built mixed chains is documented with migration guidance in both EN and ZH, which is what I was looking for. Thanks @nzw921rx for finishing this phase of #11052, and for merging `dev` promptly — this one was well prepared. I'm happy for a maintainer with write access to take the final approval step; I don't have write-level review controls on this repository, so I can't flip the review state myself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
