JeremyXin commented on PR #11841: URL: https://github.com/apache/seatunnel/pull/11841#issuecomment-6259392880
Thanks @SEZ9. I rechecked all six points against the current head c1c542de8cc8: 1. JobImmutableInformation.readData() initializes restoreMode from the legacy boolean before reading the optional trailer (JobImmutableInformation.java:259–268). A legacy payload with isStartWithSavePoint=true therefore resolves to SAVEPOINT, as covered by shouldReadLegacyPayload. 2. ClientJobProxy now sends isSavepointRestore(). For constructed payloads, this has the same value as the previous isStartWithSavePoint() flag: true only for SAVEPOINT (JobImmutableInformation.java:117–119). The wire field and its layout remain unchanged. 3. You are right that the restore branch in handleSaveMode is unreachable through JobMaster.init. The previous guard also skipped restore jobs, so changing cluster-side sink initialization needs a separate behavior decision and regression test. I will track that separately; this PR does not claim to fix it. 4. The pending-cleanup and existing-metrics branches in CoordinatorService.submitJob are unchanged by this PR; its diff only adds a comment there. I will fill in the currently blank user-facing-change and testing sections of the PR description, including the existing checkpoint-restore behavior and the relevant tests, without presenting it as a newly introduced breaking change. 5. JobMaster.initCheckPointManager passes isRestoreJob() || restart at JobMaster.java:342; CheckpointManager forwards it to CheckpointCoordinator at CheckpointManager.java:149–160. 6. The current submitJob has no null-guard followed by an unconditional restoreMode dereference. Legacy deserialization resolves the mode before downstream use. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
