nzw921rx commented on PR #11841: URL: https://github.com/apache/seatunnel/pull/11841#issuecomment-6268847163
**P1 (compatibility): public/protected API signatures were replaced instead of extended.** `MultipleTableJobConfigParser`'s 8-arg/7-arg boolean constructors (`MultipleTableJobConfigParser.java:187-213`), `JobMaster.handleSaveMode(SeaTunnelSink, boolean)` (`JobMaster.java:780`), and the protected `AbstractJobEnvironment.isStartWithSavePoint` field (`AbstractJobEnvironment.java:45`) are removed or changed to `RestoreMode` without compatibility overloads. These are public/protected members in published engine modules, so code compiled against a previous release will fail with `NoSuchMethodError`/`NoSuchFieldError`, and subclasses will no longer compile. The PR also does not update `docs/en/introduction/concepts/incompatible-changes.md` or the zh version, despite the repository's compatibility rule. Please keep the old boolean signatures as `@Deprecated` delegates to the new `RestoreMode` versions (and keep the protected field or add a deprecated accessor), or document the break in both `incompatible-changes.md` files with migration guidance. Additive overloads would also avoid the current `dev` merge compile break at `ApplicationJobExecutionEnvironment.java:91`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
