DanielLeens commented on PR #12828: URL: https://github.com/apache/seatunnel/pull/12828#issuecomment-6266190861
Quick status update so this thread isn't sitting on a stale CI fact. In my last review I flagged the class-name CI failure and then re-reviewed `941e31e40c` once it was fixed. Since then: - **CI is green on this head.** `Build` on `941e31e40c` has completed successfully, so the class-name failure I raised is fully resolved and nothing on the CI side is outstanding. - **The remaining gate has changed, though — it's now merge conflicts.** GitHub reports this branch as `diverged` from `dev` (`behind_by = 37`, `ahead_by = 4`) and `mergeable_state: dirty`, so `dev` has moved on since this head was cut. Could you please sync with the latest `dev` and resolve the conflicts? Once that's pushed and the checks rerun, I'm happy to take another pass. My source-side conclusion on `941e31e40c` is unchanged: no new problems, and the earlier non-blocking items I listed are still the only open notes. For transparency on what the sync may touch, since the dialect subclasses `PostgresDialect`: the most likely conflict sites are the dialect factory/option list and whatever `PostgresDialect` members this dialect overrides (`FNV32` splitting, the `COUNT(*)` row count, and the row converter). If `PostgresDialect` has changed shape on `dev`, those overrides are the places worth re-checking after the merge rather than assuming they still line up. Thanks @goutamadwant — the dialect and its ITs are well put together, and this is just the usual upstream-drift dance at the end. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
