SEZ9 commented on PR #12578: URL: https://github.com/apache/seatunnel/pull/12578#issuecomment-6282061411
Thanks @hutiefang76 — I rechecked head `ef53a70c6f72f5f6ae7c31fcc57b541eb3c849f3` and have no remaining source-side findings. - The conditional `size = 0` in `setField` is fine as-is; I'm not asking for any change there. - The typed→untyped, untyped→typed, direct backing-array mutation and nested-object mutation tests cover the earlier test points. - Thanks for pointing to the Javadoc on `setField` describing the invalidation contract and the `getFields()` / nested-object limitation — that is the placement I was after. The only remaining gate is operational: as you noted, the Notify job hit a GitHub API 500 before any tests ran, so there is no Build result on this head yet. Once a Build run exists for this exact commit (or for a new head, which I'd re-review), a write-access maintainer can complete the final approval/merge. <!-- streview-comment:1888 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
