SEZ9 commented on PR #12169: URL: https://github.com/apache/seatunnel/pull/12169#issuecomment-6282669227
Thanks for the follow-up on the earlier points (the homogeneous dynamic-slot note, the tag-filter exclusion and the new regression test) — nothing further from me on those. Two things are still open: 1. **Conflicts.** As @nzw921rx asked, please merge/rebase onto `dev` again and resolve the conflicts. The last two heads (`7ad4f16a32` and `23455153cda`) were dev-merge-only commits with the PR-owned files identical to `c07901ec66`, so this should be a mechanical fixup. Once the new head is pushed I'll re-diff the PR-owned files against `dev` myself to confirm the autoscaler content is unchanged apart from the conflict resolution. 2. **Config placement.** @nzw921rx's inline question about `AutoscaleRuntimeConfig` being too tightly bound to the engine startup path and possibly belonging in `EngineConfig` still has no response from your side. I gave my view on it in my previous two reviews (Issues 1 and 2), so it would help to hear back on that thread — either with the move or with your reasoning for the current placement — since the Slice 2 config will have to live wherever we settle this. I'll take another pass as soon as both are addressed. <!-- streview-comment:1896 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
