DanielLeens commented on PR #12169: URL: https://github.com/apache/seatunnel/pull/12169#issuecomment-6397821044
Thanks for the contribution. The CI/merge fact in my previous review has changed. The exact-head [fork Build](https://github.com/JeremyXin/seatunnel/actions/runs/40111264670) is now **completed with failure** for `b433b42ebb0a3b01bdbc475c97e96752cdfc9cfc`. This is a gate correction, not a second full source review of that unchanged head. The previously in-progress fork run is now completed with failure. The inspected [all-connectors-it-1 Java 11 job](https://github.com/JeremyXin/seatunnel/actions/runs/40111264670/job/120924198613) fails at `HdfsFileIT.testHdfsBinaryUpdateModeContinuousDiscoveryPostSyncDelete:387 -> cancelContinuousJob:665`: the cancellation command exits 1 and its stack reports `TaskGroupContextNotFoundException` while a source requests a split. The corresponding job passed on JDK 17 in the collected run; this does not make the failed JDK 11 leg a pass. The HDFS test is unchanged in latest dev, and no matching merged cancellation fix was identified; related [#12311](https://github.com/apache/seatunnel/pull/12311) is still open. Syncing is not a demonstrated cure. Please rerun just the failed job, preserving the failing log for the shared engine/cancellation investigation if it repeats. No autoscaler change is supported by this failure, since the feature is disabled on that path. The earlier engine-server UT execution gap remains closed by the actual passing engine-server tests already documented. Comparison against dev is `diverged`, ahead 35 / behind 3; merge conflicts: no. Drift is recorded independently and does not itself justify a sync request. No new source-level blocker from my previous full review is asserted here; a successful required Build and write-capable maintainer approval remain separate gates. Daniel has READ permission, so this comment is not an effective approval. Thanks for keeping the fix focused. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
