zhengxiang378928908-code commented on PR #10755: URL: https://github.com/apache/seatunnel/pull/10755#issuecomment-6310408975
As proposed above, I've opened #12937 to continue this fix, building on this PR with @chl-wxp as co-author. @DanielLeens, it covers your review items: `flush_row_size > 0` validation, EN/ZH docs, and focused tests. On the upsert issue: I kept rotation in all modes (append-only rotation wouldn't help the upsert load in #10623) and made the committer split a checkpoint into ordered snapshots whenever equality deletes follow a rotation. That way they apply to rows written earlier. The INSERT → rotate → DELETE/UPDATE tests are included. Committing the same files as a single RowDelta reproduces the stale row you described. The same thing already happens on `dev` when a schema change occurs inside a checkpoint in upsert mode, and this fixes that too. Details are in the PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
