DanielLeens commented on PR #10755: URL: https://github.com/apache/seatunnel/pull/10755#issuecomment-6313679309
Thanks @zhengxiang378928908-code for following through and linking #12937, and thanks again @chl-wxp for starting this fix and for the approach it builds on. Status for this PR: head `1540446d4c` is still the one I reviewed on 2026-04-12 (no new commits, and it is still a draft), so my two blockers here are unchanged and I have no new code feedback on this branch. I will not re-review #12937's diff in this thread; I will pick it up on that PR so the discussion stays in one place. One thing I can confirm from reading the description of #12937 is that it targets the exact gap I raised: rotating the task writer alone is not safe in upsert mode, because an equality delete in the same snapshot as its target data file is not applied (Iceberg applies equality deletes only to data files with a smaller sequence number), so committing rotated results in order is the right direction. Whether the ordered-snapshot commit fully holds (including the schema-change-inside-a-checkpoint case you mention) is something I want to verify against the code and the new rotation tests rather than take from the description, so I will give a source-level answer on #12937. @chl-wxp, no action is needed on your side beyond letting us know if you would rather continue here instead; closing or superseding this PR is a maintainer decision and nothing is being closed by this comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
