zhangshenghang commented on PR #12941: URL: https://github.com/apache/seatunnel/pull/12941#issuecomment-6330187569
All three review points are addressed in a74dc4653: 1. **Prometheus `retry`** (en+zh): default reverted to `3`; the row now says the sink applies an effective default of `3` when the option is omitted and that `0` disables retries; the 'no default in code' wording is dropped. 2. **LLM `api_key`** (en+zh): `QIANFAN` added to the conditionally-required list, noting it is required together with `secret_key` and `oauth_path`; the unverified 'other providers need it at runtime' claim is removed. 3. **sink-common-options Important note** (en): now states directly that `plugin_input` is only mandatory when the job has more than one source, transform or sink. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
