zhangshenghang commented on PR #12602: URL: https://github.com/apache/seatunnel/pull/12602#issuecomment-6331321831
All three review points are addressed in d4b287965: 1. **Debezium warning** (en+zh): reworded to state that `debezium-json.ignore-parse-errors` is not read from the job configuration, that the Kafka source always skips rows with parse errors in `debezium_json` format, and that the Amazon SQS source fails on them — no 'always fail' claim remains. On this head Kafka and Amazon SQS are still the only `debezium_json` consumers I could find. 2. **ClickhouseFile options** (en+zh): the blanket sentence is replaced with the explicit list `host`, `database`, `table`, `username`, `password`, `clickhouse.config`, `sharding_key`, `server_time_zone` — `clickhouse.config` is kept because `ClickhouseFileSinkFactory` reads it directly (`readonlyConfig.get(CLICKHOUSE_CONFIG)` at line 99, feeding `FileReaderOption`) even though it is not in the option rule. The sentence now also names the notable excluded options (`bulk_size`, `split_mode`, `primary_key`, `support_upsert`, `schema_save_mode`, `data_save_mode`). 3. **kafka-compatible-kafkaconnect-json table** (en+zh): pipes aligned and the format value lower-cased to `compatible_kafka_connect_json`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
