zhangshenghang commented on PR #12423: URL: https://github.com/apache/seatunnel/pull/12423#issuecomment-6330499183
Issues 1-4 are addressed in 1b89f5cda: 1. **Maxcompute `datetime_format`** (en+zh): the deletion hunks are dropped; the option table row and the `datetime_format` section are restored to the current dev wording. 2. **QIANFAN / `secret_key` / `oauth_path`** (en+zh): removed from the LLM pages entirely — provider list back to dev, the QIANFAN tip, the table rows and both sections are gone, so users can no longer be steered into the `Unsupported model provider` startup failure. 3. **`process_batch_size` / `model_retry_*` / `model_request_timeout_ms`** (en+zh): all five table rows and sections removed from the LLM pages; they remain documented on the Embedding page where they take effect. 4. **api_key wording**: now states only that it is required for `OPENAI`, `DOUBAO` or `MICROSOFT`; the 'not required for other providers' claim is gone. One note: #12941 (same batch) was told earlier to add `QIANFAN` to its `api_key` conditional-required sentence based on the option rule; your deeper call-chain finding here shows that is the wrong direction, so I will align #12941's LLM page with this removal in its next round. Issue 5 (MySQL-CDC skip default dash) is still open, left as the optional Low item. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
