zhangshenghang commented on PR #12459: URL: https://github.com/apache/seatunnel/pull/12459#issuecomment-6330992493
All seven review points are addressed in e1ff7a3c3: 1. **Prometheus `retry`** (en+zh): default restored to `3` with 'When unset, defaults to 3 retries'; `0` disables retries. 2. **DuckDB unsigned rows** (en+zh): the four rows are reverted to the current dev wording, so this PR no longer conflicts with #12508; the other DuckDB corrections are kept. 3. **JDBC sink dialect table** (en+zh): the stray `DSQL` cell is removed; the table now ends `DuckDB | YashanDB` as on the source page. 4. **state-storage-and-recovery** (en+zh): the MapStore persistence is now described as an append-only write-ahead log (FileMapStore → IMapFileStorage, shared region files); the 'delete files of expired jobs' advice is replaced with volume sizing plus a full-namespace wipe with the cluster stopped, in the maintenance section, the troubleshooting fix and the cleanup checklist. 5. **zh Snowflake geospatial sentence**: aligned with the en page (mapped to `STRING`). 6. **Snowflake `p > 38`**: the sink rows now document `DECIMAL(38, s - (p - 38))` (minimum scale 0) and the unimplementable source row is dropped. 7. **Capacity formula**: the `max_concurrent_checkpoints` factor is removed with a note that only one checkpoint is in flight. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
