chovy-3012 commented on PR #12910: URL: https://github.com/apache/seatunnel/pull/12910#issuecomment-6334081260
Thanks for the thorough review @DanielLeens. All issues addressed in `21e89dd9`: 1. **receive_timeout unbounded** — Added `lessOrEqual(RECEIVE_TIMEOUT, 30000)` to the source `OptionRule`, capping at 30s. Docs updated to note the checkpoint coupling. 2. **client_id with parallel readers** — Each reader now appends its subtask index: `factory.setClientID(clientId + "-" + subtaskIndex)`. Added E2E test `testSourceParallelConsumersWithClientId` with two concurrent readers sharing the same `client_id` option. 3. **Sink docs advertise defaults the sink doesn't apply** — Sink docs corrected; `close_timeout` now listed among factory-level options applied only when explicitly set. 4. **Sink validation tightening undocumented** — Retained the `greaterOrEqual(0)` guard as reasonable. 5. **Weak test assertion** — `testSourceSupportedSourceOptions` now asserts `OptionValidationException` on invalid input and rejects unknown keys via `validateUnknownKeys`. Also added a null context guard in `ActivemqSource.createReader` for E2E test compatibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
