chovy-3012 commented on PR #12910: URL: https://github.com/apache/seatunnel/pull/12910#issuecomment-6448104148
Thanks @DanielLeens. All four Low items are addressed in `593a1dc64`. 1. **30s cap / checkpoint coupling** — kept the 30000 cap and default of 200 as you accepted documentation for this non-blocking item. The wording fix in #2 below makes the coupling explicit. 2. **Doc named the wrong lock** — corrected `receive_timeout` in en/zh: "holds the reader's monitor — the same lock that guards `snapshotState` and the checkpoint complete/abort callbacks" (it is not `output.getCheckpointLock()`, which is taken only around emission). 3. **Test-only null-context branch** — dropped the `context == null ?` guard in `ActivemqSource.createReader`. Verified no test calls `createReader` (unit tests use the package-private ctor with a `ConnectionFactory`; E2E runs the full engine pipeline, which always supplies a non-null `SourceReader.Context`). 4. **Fixed `clientID` reuse on reconnect** — appended a note to `client_id` in en/zh: a restart may fail with `javax.jms.InvalidClientIDException` until the broker releases the previous connection's ID; recover by omitting `client_id` or waiting for the broker's connection-timeout. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
