SEZ9 commented on PR #11814: URL: https://github.com/apache/seatunnel/pull/11814#issuecomment-6393258922
Thanks for resolving the conflict with `dev`. Since the PR-owned patch at `d5328f28aa9e86afcf56cb029dbc192b2707141c` is identical to `131de7f704`, the handler points already verified in this thread still hold: redirects are rejected via `followRedirects(false)` / `followSslRedirects(false)`, `close()` only flushes once the scheduler has stopped and always runs `dispatcher().cancelAll()` and `connectionPool().evictAll()` in `finally`, and the Kotlin runtime is pinned to 1.9.10 in the module. Two things remain from my side: - **Dependency/license inventories**: the merge with `dev` left duplicate entries (OkHttp, Okio, JetBrains annotations, `kotlin-stdlib-common`, and a Public Suffix List attribution). Please dedupe so each jar/attribution appears once and the versions match what the dist actually resolves. - **E2E wait strategy, `testRetryAfterHttpFailure`, and the Content-Type charset**: I haven't yet seen a diff that addresses these earlier points. Could you point me to where they were handled, or let me know if you'd prefer to follow up separately? Happy to take another look after that. <!-- streview-comment:2023 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
