DanielLeens commented on PR #11408: URL: https://github.com/apache/seatunnel/pull/11408#issuecomment-6393645056
An update to the earlier guidance: the runtime problem in #11013 was already addressed by merged [#11113](https://github.com/apache/seatunnel/pull/11113) (`94b4ac59ddc`) and the slow-region follow-up [#11407](https://github.com/apache/seatunnel/pull/11407) (`4c7f41373b1`). Both commits are present in current `dev` at `d676f91b3d6aaa2cca693816697a211e4d384805`. The issue was closed as completed on July 12. The current Java reader [uses the minimum region resolved timestamp](https://github.com/apache/seatunnel/blob/d676f91b3d6aaa2cca693816697a211e4d384805/seatunnel-connectors-v2/connector-cdc/connector-cdc-tidb/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/tidb/source/reader/TiDBSourceReader.java#L267), [retains a commit until its prewrite arrives](https://github.com/apache/seatunnel/blob/d676f91b3d6aaa2cca693816697a211e4d384805/seatunnel-connectors-v2/connector-cdc/connector-cdc-tidb/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/tidb/source/reader/TiDBSourceReader.java#L394), and contains the region-aware snapshot scan. The [reader regression tests](https://github.com/apache/seatunnel/blob/d676f91b3d6aaa2cca693816697a211e4d384805/seatunnel-connectors-v2/connector-cdc/connector-cdc-tidb/src/test/java/org/apache/seatunnel/connectors/seatunnel/cdc/tidb/source/reader/TiDBSourceReaderTest.java#L54) cover slow-region progress and delayed prewrite matching. This branch is still `f0b0eb1e1d36` and adds only six Python sketches. A second watermark-reset implementation is not needed for that already-fixed issue. If there is a distinct remaining failure, please reproduce it against the current Java implementation and scope a new Java delta to that case. The existing `Build: ACTION_REQUIRED` reports missing workflow-run detection; it is not an executed failing connector test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
