davidzollo commented on PR #10472: URL: https://github.com/apache/seatunnel/pull/10472#issuecomment-6393865084
Pushed the review repair and latest `dev` sync in `584c3658c8fc`. HANA `CHAR` is read as SeaTunnel `STRING` with its raw byte length. Sink table creation retains the existing `STRING` mapping to `NVARCHAR` (up to 5000) or `CLOB`; the unmerged branch that treated every upstream `sourceType=CHAR` as HANA ASCII `CHAR` has been removed, because the type name does not identify its source dialect. The existing converter test now covers CHAR read lengths and STRING recreation with CHAR source metadata at null, 10, 2000, 2001, 5000 and 5001 lengths. The existing HANA IT now asserts the real CHAR field types/widths through both catalog paths, and `CHAR_VALUE_15` matches its declaration. English/Chinese JDBC documentation explains the behavior. Scoped Spotless formatting passed and the final patch received independent maintainer review. GitHub CI on this new head still needs to compile and execute the converter/HANA tests; I am not claiming runtime acceptance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
