DanielLeens commented on PR #10472: URL: https://github.com/apache/seatunnel/pull/10472#issuecomment-6414848512
Thanks @davidzollo, that is exactly the execution evidence my last review was missing, and I checked it myself rather than relying on the summary. Job `updated-modules-integration-test-part-7 (11, ubuntu-latest)` ran for exactly head `1059429d` and concluded `success`, and its log shows `JdbcHanaIT` executing (testCreateIndex, testCatalogWithCatalogUtils, testJdbcDb and the rest) on the real HANA container. The apache-side `Build` for this head is also green. So the one open item in my previous review (confirm the modified HANA IT actually ran) is closed. Note that the `jdbc-connectors-it-part-6` lane being skipped is expected for this change-detection setup: the changed modules were routed through the `updated-modules-*` lanes, which is the broader coverage, not a gap. State from my side for head `1059429d`: - No remaining source-level blocker; sink behavior is unchanged relative to dev and only the read-side `CHAR -> STRING` mapping is added. - CI: green. - Remaining gate is purely the repository review/merge requirement (my review is a COMMENT from a non-write account and does not count toward it), so a write-capable maintainer approval is what is left. @SEZ9, since your earlier `CHANGES_REQUESTED` was filed against `22fb8a5c` and targeted a `reconvert()` branch that has since been removed, an updated review state on this head would unblock the gate. Thanks again @dik111 for the original contribution and for keeping the branch open to maintainer updates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
