sudeephazra commented on PR #12293:
URL: https://github.com/apache/seatunnel/pull/12293#issuecomment-6395516451
@DanielLeens Both items you pointed out are addressed in the latest commit
d283237afd9a3ecec490f4788ffa84b89395dc31
Blockers (must fix)
Issue 1: restore the fs.s3 prefix and add an fs.s3a.* key to the validator
test. ✅
Issue 2: update the blocked-key lists in the four ADLSFile reference pages.
✅
@SEZ9 `fs.s3` is not required and was dropped on purpose. This is a residue
from a different test. For the items that you pointed out earlier, please see
the responses below (they remain unchanged)
F1:
[ADLSHadoopConf.java:61](https://github.com/apache/seatunnel/blob/e4fa7bf9b3672510df0b17cdf3227bc82df850d4/seatunnel-connectors-v2/connector-file/connector-file-adls/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/adls/config/ADLSHadoopConf.java#L61)
consumes the trimmed values returned by ADLSConfigValidator.required() for
routing and authentication options.
F2: The [English sink
prerequisite](https://github.com/apache/seatunnel/blob/e4fa7bf9b3672510df0b17cdf3227bc82df850d4/docs/en/connectors/sink/ADLSFile.md#L39)
explicitly ties transactional commit/exactly-once to HNS and requires tmp_path
and path in the same container; the Chinese reference matches.
F3: [ADLS configuration
rules](https://github.com/apache/seatunnel/blob/e4fa7bf9b3672510df0b17cdf3227bc82df850d4/docs/en/connectors/sink/ADLSFile.md#L100)
document naming, auth mutual exclusion, and blocked keys; the
[template](https://github.com/apache/seatunnel/blob/e4fa7bf9b3672510df0b17cdf3227bc82df850d4/config/v2.batch.adls.config.template#L39)
uses naming-valid replacewithaccount / replacewithcontainer placeholders.
F4: [Runtime
validation](https://github.com/apache/seatunnel/blob/e4fa7bf9b3672510df0b17cdf3227bc82df850d4/seatunnel-connectors-v2/connector-file/connector-file-adls-runtime/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/adls/config/ADLSRuntimeCompatibility.java#L179)
checks HTTPS-origin/hostname syntax and GUID/DNS tenant format; [both checks
precede token URL
construction](https://github.com/apache/seatunnel/blob/e4fa7bf9b3672510df0b17cdf3227bc82df850d4/seatunnel-connectors-v2/connector-file/connector-file-adls-runtime/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/adls/config/ADLSRuntimeCompatibility.java#L133).
Host trust remains operator-controlled; there is no hostname allowlist.
F5: The en/zh source and sink tables contain the same option keys and cover
those registered by their respective factories, including conditional options.
F6: The [configuration
guide](https://github.com/apache/seatunnel/blob/e4fa7bf9b3672510df0b17cdf3227bc82df850d4/docs/en/introduction/configuration/config-encryption-decryption.md#L25)
documents the global account_key log-mask default and distinguishes it from
encryption; the connector references also explain its cross-connector effect.
F7: The [English source
table](https://github.com/apache/seatunnel/blob/e4fa7bf9b3672510df0b17cdf3227bc82df850d4/docs/en/connectors/source/ADLSFile.md#L74)
now lists discovery_mode = ONCE and start_mode = EARLIEST, matching the code
and Chinese reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
