DanielLeens commented on PR #12858: URL: https://github.com/apache/seatunnel/pull/12858#issuecomment-6397817611
Thanks for the contribution. The CI/merge fact in my previous review has changed. The exact-head [fork Build](https://github.com/karthik-0306/apache-seatunnel/actions/runs/40076614568) is now **completed with failure** for `ebe122b2359030f467dcd6cd8156fa2dbd2aabab`. This is a gate correction, not a second full source review of that unchanged head. The [Java 11 engine job](https://github.com/karthik-0306/apache-seatunnel/actions/runs/40076614568/job/120821749534) failed in `BackpressureSlowSinkIT.testCheckpointsKeepCompletingUnderSustainedBackpressure`, observing only two additional completed checkpoints within 90 seconds. This replaces my earlier in-progress run description; it is the same engine failure already discussed, and the Python helper cannot exercise that engine locking path. The test and relevant upstream checkpoint-handoff fix status were rechecked: [#12316](https://github.com/apache/seatunnel/pull/12316) remains open, and no corresponding fix is in latest dev. Syncing now is not a demonstrated cure. Please rerun that failed job, and retain the new log with the shared engine investigation if it repeats; avoid unrelated SDK changes. Apache-side workflow approval for the Python SDK tests remains a separate maintainer action if still pending. Comparison against dev is `diverged`, ahead 4 / behind 13; merge conflicts: no. Drift is recorded independently and does not itself justify a sync request. No new source-level blocker from my previous full review is asserted here; a successful required Build and write-capable maintainer approval remain separate gates. Daniel has READ permission, so this comment is not an effective approval. Thanks for keeping the fix focused. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
